search

splunk / kafka-connect-splunk

Kafka connector for Splunk
Apache License 2.0
94 stars 102 forks source link

Add auto extract timestamp parameter support #415

Closed ludovic-boutros closed 1 year ago

ludovic-boutros commented 1 year ago

We need to be able to enable the "auto extract timestamp" feature for a project.

This parameter is not exposed yet and therefore cannot be set on the HEC URI.

This PR expose this parameter. It is not set by default to be keep compatibility with current behavior.

I have created a specific HEC URI builder in order to ease testing.

VihasMakwana commented 1 year ago

Looks good other than a couple of nits. Also, my CI has been failing lately so I'll merge it only after I get it green. It might take some time. I'll approve the PR though.

Thanks for the change, @ludovic-boutros. Appreciate it!

ludovic-boutros commented 1 year ago

@VihasMakwana It should be good now 👍 Thank you.

github-actions[bot] commented 1 year ago

Unit Test Results

169 tests   169 :heavy_check_mark:  38s :stopwatch:   24 suites      0 :zzz:   24 files        0 :x:

Results for commit 01fbcd3c.

ludovic-boutros commented 1 year ago

Thank you @VihasMakwana. Any idea of next release date ?

VihasMakwana commented 1 year ago

@ludovic-boutros Released in 2.2.0, let me know if it's good for you.

ludovic-boutros commented 1 year ago

That's perfect, thank you 👍