fix: do not log .conf parser warnings from all workers

splunk / pytest-splunk-addon

A Dynamic test tool for Splunk Technology Add-ons

https://splunk.github.io/pytest-splunk-addon/

Apache License 2.0

57 stars 20 forks source link

Closed harshilgajera-crest closed 3 months ago

harshilgajera-crest commented 3 months ago

When tests are ran with multiple workers, duplicate logging is observed because every workers logs the warning. This PR fixes that.

harshilgajera-crest commented 3 months ago

Please extract this logic in a helper function, it's been used several times already across the codebase.

Done

harshilgajera-crest commented 3 months ago

I'd consider creating separate utils file with check_first_worker() instead of having delayed imports. @artemrys wdyt?

I thought the same but because it was only one small function i thought it was not needed, but we can do that.

srv-rr-github-token commented 3 months ago

:tada: This PR is included in version 5.3.0-beta.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

srv-rr-github-token commented 3 weeks ago

:tada: This issue has been resolved in version 5.4.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: