search

splunk / sck-otel

Apache License 2.0
9 stars 5 forks source link

Add new k8s tagger changes #22

Closed chaitanyaphalak closed 3 years ago

rockb1017 commented 3 years ago

Thank you. Note to future self. we will merge this when 0.29.0 is released on otel collector

rockb1017 commented 3 years ago

with just this change, we pull namespace labels and annotation?

chaitanyaphalak commented 3 years ago

@rockb1017 we are pulling the default metadata for pods. I think the labels and annotation will be user configured in https://github.com/splunk/sck-otel/blob/main/charts/opentelemetry-collector/values.yaml#L62 so we don't pull any by default. Let me know if we need to pull some labels/annotations from namespaces, we can add in this PR.

rockb1017 commented 3 years ago

For annotations and labels they have specified, lets collect from both pod and namespace.

rockb1017 commented 3 years ago

Could you rebase? i upgraded to app version to 0.29. https://github.com/splunk/sck-otel/pull/26