splunk / security_content

Splunk Security Content
https://research.splunk.com
Apache License 2.0
1.3k stars 362 forks source link

RBA Migration #3204

Open ljstella opened 4 days ago

ljstella commented 4 days ago

Details

Content migration accompanying changes to contentctl: https://github.com/splunk/contentctl/pull/263

Checklist

Notes For Submitters and Reviewers

ljstella commented 2 days ago

Status update:

I have (temporarily) changed the GitHub Actions config in my PR (https://github.com/splunk/contentctl/pull/263) to run the ESCU smoketest against this branch.

Here are the latest results: https://github.com/splunk/contentctl/actions/runs/11860779327/job/33057262480?pr=263

As of this point, there are now under 100 validation errors against translated content.

The vast majority of these will need to be handled individually. Up until this point, commits have generally been done by subdirectory of detections/ with all of the changes for those in each one to assist in review. If you're reviewing this change at a later point, this is a great time to go refill your coffee ☕ and grab a snack 🍿 . I will attempt to group similar fixes and/or subdirectories together from this point forward, but they may be a bit more spread out.

ljstella commented 2 days ago

Update: as of now, all translated content is building successfully: https://github.com/splunk/contentctl/actions/runs/11863423975?pr=263

Still have to do some cleanup around messages and some risk objects, but they're all technically passing and producing a package "compatible" with the previous releases. I say compatible, as opposed to identical, because as this work was done, some changes have been made where things were threat objects but probably should have been risk objects, vice versa, and some where they just didn't make sense as either and were removed. Some risk messages were updated along the way, although there will be more of that upcoming.