splunk / splunk-add-on-microsoft-azure

Splunk Add-on for Microsoft Azure
Apache License 2.0
11 stars 9 forks source link

API version change resulting in bad requests responses (400)? #80

Closed jmartin-pro closed 2 months ago

jmartin-pro commented 5 months ago

Hello!

Thank you for your hard work in developing this app. We leverage this quite a bit!

I've been running into an issue with the Reservation Recommendation input. Based on Microsoft documentation, I believe the API version has been updated to 2023-05-01?

Based on the code below, it looks like the API version is hard-coded with an old version, which I believe could be the issue we are experiencing, since it references version 2019-05-01 (we stopped ingesting these logs at midnight today, May 1st, so I'm fairly confident this is the cause).

https://github.com/splunk/splunk-add-on-microsoft-azure/blob/6393fc6f487e37d8098eab959c90d1fa4742b3bc/package/bin/azure_reservation_recommendation.py#L104

What would the likelihood be of this API version being updated? Would there be a rough estimate of a timeline?

jmartin-pro commented 5 months ago

The sourcetype ended up reingesting on its own. It's plausible the client had reverted a minimum API version setting in the Azure portal.

However, it does seem Microsoft will be retiring these older API versions in June which would impact this eventually?