splunk / splunk-ansible

Ansible playbooks for configuring and managing Splunk Enterprise and Universal Forwarder deployments
357 stars 186 forks source link

hec.enable should be check prior to include tasks #835

Open BigCaber opened 6 months ago

BigCaber commented 6 months ago

Hi !

https://github.com/splunk/splunk-ansible/blame/e436c07777c3cfb05f1466d0e18a3828bef6e115/roles/splunk_standalone/tasks/main.yml#L2

should have implemented checks like this previous commit affecting the same file.

https://github.com/splunk/splunk-ansible/blame/eb96be01374b0a87ac01e7cbca6eba72222d830b/roles/splunk_standalone/tasks/main.yml#L4

and it should be implemented for all 4 references:

right now, hec tasks run no matter what and there is no way to skip that task, I do not understand why would anyone remove a check..

BigCaber commented 6 months ago

I forked since it does not allow me to create a branch myself, then added the commit, for reference

https://github.com/splunk/splunk-ansible/pull/836/commits/0f4cc8dcec1775376fb05b9ea7186ede4d273342