splunk / splunk-connect-for-kubernetes

Helm charts associated with kubernetes plug-ins

Apache License 2.0

344 stars 270 forks source link

fix the issue #830, pod_uid field extraction #831

Closed Kiyoshi-Miyake closed 1 year ago

Kiyoshi-Miyake commented 1 year ago

830 The pod_uid field has not only pod_uid but also namespace and pod_name.

Proposed changes

fix the issue #830 to follow the change of the pod log directory changed after k8s 1.14 or later.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected) i am concerned that the user using old k8s might be affect of this change. can we change to work for both of them?

Checklist

Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I have read the CLA
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

hvaghani221 commented 1 year ago

Hi @Kiyoshi-Miyake, sorry for the delay. I am not getting any chance to review the PR. I'll try to do this by end of the next week.

hvaghani221 commented 1 year ago

Closing the PR as discussed in https://github.com/splunk/splunk-connect-for-kubernetes/issues/830#issuecomment-1366371165