splunk / splunk-operator

Splunk Operator for Kubernetes
Other
210 stars 115 forks source link

feat: add option to add extra labels to operator pods #1226

Closed locmai closed 1 year ago

locmai commented 1 year ago

Intent

Test

Values:

# values.yaml - different from the default:
splunkOperator:
  podLabels:
    aadpodidbinding: dummy

Generated:

# Source: splunk-operator/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: splunk-operator-controller-manager
  namespace: default
  labels:
    helm.sh/chart: splunk-operator-2.3.0
    control-plane: controller-manager
    app.kubernetes.io/name: splunk-operator
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "2.3.0"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      control-plane: controller-manager
      app.kubernetes.io/name: splunk-operator
      app.kubernetes.io/instance: release-name
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        control-plane: controller-manager
        app.kubernetes.io/name: splunk-operator
        app.kubernetes.io/instance: release-name
        aadpodidbinding: dummy
...
gburton1 commented 1 year ago

@vivekr-splunk thanks for +1. Can we get this merged? Not sure about failing PR check; doesn't seem related to our change. Appreciate if we can get this merged as we have confirmed it's working well for us--we are now successfully using a managed identity!

locmai commented 1 year ago

Hi @vivekr-splunk , is there a path forward for this to get reviewed/approved/merged? I don't think the FOSSA-scanner check failed because of any change in this PR as I saw it in other PRs as well and the error message is unrelated.

locmai commented 1 year ago

Closing this as https://github.com/splunk/splunk-operator/pull/1230 merged. Thank @vivekr-splunk for taking a look!