search

splunk / splunk-sdk-python

Splunk Software Development Kit for Python
http://dev.splunk.com
Apache License 2.0
698 stars 370 forks source link

properly add parameters to request based on the method of the request #262

Closed billmurrin closed 2 years ago

billmurrin commented 5 years ago

This PR resolves #261 related to improper handling of body parameters within the Context.request method. The method used (GET or POST) will determine if the body is encoded as part of the url or passed as body into the request.

GET method requests (with and without a body) were tested and worked as expected.

billmurrin commented 5 years ago

Hi @shakeelmohamed. I've implemented the requested changes in the latest commit. Thanks!

billmurrin commented 5 years ago

Hi @shakeelmohamed - the requested changes were made. For some reason, the CI issue is still ongoing.

shakeelmohamed commented 5 years ago

@billmurrin This is not a high priority issue for us to investigate as we are severely under resourced at the moment. Unless this is 10/10 we will not look at it this week. Thank you for your patience & understanding.

cc @tdhellmann

KaterinaKop commented 3 years ago

Any news here? We are looking forward to get this fix too! @shakeelmohamed @tdhellmann