Handle `b''` strings in Python 3

splunk / splunk-sdk-python

Splunk Software Development Kit for Python

http://dev.splunk.com

Apache License 2.0

698 stars 370 forks source link

Handle `b''` strings in Python 3 #276

Closed willbowditch closed 4 years ago

willbowditch commented 5 years ago

Adds logic to fix bug described https://github.com/splunk/splunk-sdk-python/issues/275 where byte strings b'' do not work for indexing or concatenation in Python 3. This causes ReportingCommands to fail if they have a map() func.

willbowditch commented 5 years ago

The failed travis CI is unrelated to the code changes. c7f9a0c and 038138f are identical apart from a dummy file used to trigger the build.

hanswurscht commented 4 years ago

I'm hitting the same bug. Can someone merge this please?

amysutedja commented 4 years ago

After some investigation: I believe that we have fixed this issue as a side effect of fixing some other Python 3-related problems in 1.6.13. This code seems to be covered in tests/searchcommands/test_searchcommands_app.py::TestSearchCommandsApp::test_sum_as_unit which used to fail when run in Python 3, but now works.

Closing this PR.