amysutedja
commented
4 years ago Worked with @aij to dig into this and understand what's going on, and the issue is essentially that the v2 protocol can't deal with partial chunks at all. The fix removes the concept of partial chunking completely for v2. There are a couple of cleanup things we can do, but we'll do them separately. Approving.
peterchenadded
The external search command should be sending one chunk response for every chunk received, but extra flushing in the case of large chunks was producing multiple responses per request.
This changes partial flush() to be a noop for v2, and is more explicit about matching up read_chunk and write_chunk calls.
Fixes #150