SearchCommand._execute_v2() writes records as soon as a result from the chunk is processed, rather than capturing a generator of all the records from the chunk, and then writing.
Reverting a few logics
Reintroduced SearchCommand._records_protocol_v2
Remaining action items
May need to refactor SearchCommand._records_protocol_v2() to leverage SearchCommand._read_csv_records(), though the reading may need to be processed in a higher layer.
May need to refactor SearchCommand._execute_v2(), since it is only used by generating_command.py, as such we may want a common abstract interface for all commands using the v2 protocol.
SearchCommand._execute_v2()
writes records as soon as a result from the chunk is processed, rather than capturing a generator of all the records from the chunk, and then writing.SearchCommand._records_protocol_v2
SearchCommand._records_protocol_v2()
to leverageSearchCommand._read_csv_records()
, though the reading may need to be processed in a higher layer.SearchCommand._execute_v2()
, since it is only used bygenerating_command.py
, as such we may want a common abstract interface for all commands using the v2 protocol.