search

splunk / splunk-sdk-ruby

Splunk Software Development Kit for Ruby
http://dev.splunk.com
Apache License 2.0
36 stars 21 forks source link

Resolved many of the comments from the code review. #13

Closed madhadron closed 11 years ago

madhadron commented 11 years ago

Added Context#request_by_url method and made Context#request dispatch its actual requests through it. Made Splunk::namespace take a hash of arguments instead of positional arguments. Renamed "user" argument of namespace to "owner". Made all XML library switches read $splunk_xml_library instead of the mishmash that was there before. Removed the ability to set the XML library to use in an environment variable. Removed :scheme, :host, and :port arguments from Context#request. Now it uses the Context's instance variables only.

davidfstr commented 11 years ago

@madhadron, left some comments for you.