Another big round of work to merge in.

splunk / splunk-sdk-ruby

Splunk Software Development Kit for Ruby

http://dev.splunk.com

Apache License 2.0

36 stars 21 forks source link

Another big round of work to merge in. #14

Closed madhadron closed 11 years ago

madhadron commented 11 years ago

Added saved searches and a users collection. Two of the four examples I'm planning added. Lots of ghastly little namespace changes to make stuff usable from outside the Splunk module. Renamed SplunkTestCase to TestCaseWitSplunkConnection for Michael. Edited README.md. Using metaprogramming to generate separate methods for each of the atom feed and results reader tests. Added convenience methods to Service for starting the three kinds of search job.

davidfstr commented 11 years ago

Overall looks very good.

Just a few significant items:

omission of job.is_done? from the breaking changes in the release notes
terminology unification related to namespaces: non-wildcarded == "is proper" (Ruby), "is exact" (PHP)

Go ahead and merge after this. (And resolve the related JIRAs.)