search

splunk / splunk-sdk-ruby

Splunk Software Development Kit for Ruby
http://dev.splunk.com
Apache License 2.0
36 stars 21 forks source link

rake should be a "development" dependency to avoid rake versioning collisions with other gems #37

Closed bigsur0 closed 10 years ago

bigsur0 commented 10 years ago 

cmd: git diff splunk-sdk-ruby.gemspec
diff --git a/splunk-sdk-ruby.gemspec b/splunk-sdk-ruby.gemspec
index 57d10d8..2f4590d 100644
--- a/splunk-sdk-ruby.gemspec
+++ b/splunk-sdk-ruby.gemspec
@@ -13,7 +13,7 @@ Gem::Specification.new do |gem|

   gem.required_ruby_version = '>=1.9.2'
   gem.add_dependency 'jruby-openssl', '~>0.7.7' if RUBY_PLATFORM == "java"
-  gem.add_dependency 'rake', '~>10'
+  gem.add_development_dependency 'rake', '~>10'
   gem.add_development_dependency 'test-unit', '~> 0'

   gem.files         = Dir['{lib,examples,test}/**/*',
bigsur0 commented 10 years ago

From: http://guides.rubygems.org/patterns/#declaring-dependencies

... snip ...

Development dependencies are useful for when someone wants to make modifications to your gem. When you specify development dependencies, another developer can run gem install --dev your_gem and RubyGems will grab both sets of dependencies (runtime and development). Typical development dependencies include test frameworks and build systems. ... snip ...