search

splunk / splunk-sdk-ruby

Splunk Software Development Kit for Ruby
http://dev.splunk.com
Apache License 2.0
36 stars 21 forks source link

Break client.rb into separate Class dir/files? #7

Closed benwoody closed 12 years ago

benwoody commented 12 years ago

As it stands, lib/splunk-sdk-ruby/client.rb is 1200 (TWELVE HUNDRED!) lines long. Wondering if there is a reason behind this or would the team be open to a pull request breaking it into subsequent folders and files per Class, subClass?

ampledata commented 12 years ago

There's no particular reason client.rb is so large. I for one would wholly welcome any effort to cleanup that file.

itay commented 12 years ago

@benwoody yes, we would definitely be open to that. All we're looking for is maintaining an architectural similarity to our other SDKs, but even in Python we're probably going to end up splitting up the client.py into multiple files.

madhadron commented 12 years ago

We've ended up at thousands of lines in a couple of the SDKs by steady accretion, and no one has gotten around to breaking them into pieces. If you want to, go right ahead.

benwoody commented 12 years ago

I've added a pull request for this: https://github.com/splunk/splunk-sdk-ruby/pull/8

benwoody commented 12 years ago

Fixed with the merge @589b51248a6cdf5ccf9e0fb8b4c16c593cd9f10d