search

splunk / splunk-sdk-ruby

Splunk Software Development Kit for Ruby
http://dev.splunk.com
Apache License 2.0
36 stars 21 forks source link

Client cleanup #8

Closed benwoody closed 12 years ago

benwoody commented 12 years ago

In response to https://github.com/splunk/splunk-sdk-ruby/issues/7

This pushes all classes (with the exception of the JSON::Stream::Parser class) into it's own file.

These classes live inside the client dir, with the subclasses inside dirs based on their parent class.

Tests that passed before this commit pass. However, I don't have access to an admin account to test admin functions to begin with.

itay commented 12 years ago

Did any content change in the functions, or were things just copied over?

itay commented 12 years ago

@benwoody can you sign the individual contributor agreement:

http://dev.splunk.com/goto/individualcontributions

benwoody commented 12 years ago

Signed.

The only code difference is that lib/splunk-ruby-sdk/aloader.rb and lib/splunk-ruby-sdk/context.rb are included within the Splunk module now. Before this, these files were loaded twice. This gets rid of the need to include them in client.rb instance.

99.9% of this commit is aesthetic.

itay commented 12 years ago

OK - wanted to make sure I didn't lose the signal in the noise, thanks for clearing it up! I'll run it against an admin-authenticated instance.

benwoody commented 12 years ago

Does this need more reviewing?

itay commented 12 years ago

Thanks for the request - sorry for the delay!