Test untested code or re-implement with test first. (smaller tasks) - Githubissues

splunk / splunk-shuttl

Splunk app for archive management, including HDFS support.

Apache License 2.0

36 stars 19 forks source link

Test untested code or re-implement with test first. (smaller tasks) #12

Closed petterik closed 12 years ago

petterik commented 12 years ago

The following intentions were implemented without test first and either needs re-implementation or tests.

BucketThawer:

Instead of returning a map with <"failed", bucket> and <"thawed", bucket>, leave thawBuckets to be void. Then create getters for failed buckets and thawed buckets, that returns lists that can be iterated.

SplunkSettings:

Test that when a splunk index does not exist, a SplunkIndexNotFound exception is thrown.

ThawBucketTransferer:

Test expecting IOException

ArchiveFileSystem:

getSize() is untested and probably the wrong way to go. It's it better to persist the local file size in the name, since a lot can happen on the remote file system. There's no way of knowing if it's the correct file size when back on local disk.

ArchiveRestHandler

Test for expecting HttpResponseException
Test for expecting RuntimeException at: handleIOExceptionGenereratedByDoingArchiveBucketRequest()