search

splunk / splunk-webframework-toolkit

The Splunk Web Framework Toolkit
Apache License 2.0
12 stars 13 forks source link

Added a click trigger to Sunburst. #8

Open hobbes3 opened 10 years ago

hobbes3 commented 10 years ago

Added a click trigger that pass the entire clicked object "d".

I also did some code syntax cleaning based off of JSLint's recommendations (also my .vimrc removes unnecessary whitespace).

itay commented 10 years ago

@hobbes3 thank you for the pull request!

A couple of notes:

  1. Can you sign the contributor agreement?
  2. Can you rebase the fix against develop instead of master?

While not a problem for this commit, in general, it's better to not modify white spaces automatically when contributing to a project. It makes it hard to keep one style, and adds a lot of noise to the diff.

Thanks again!