search

splunk / terraform-provider-splunk

Terraform Provider for Splunk
Mozilla Public License 2.0
104 stars 78 forks source link

Update defaults and fix setting of some 0 values. #52

Open zscholl opened 3 years ago

zscholl commented 3 years ago

Description

When the values are Computed: true terraform ends up using false for boolean values and 0 for integer values. In some cases this is not the true default value when creating a saved search, so this produces behavior that's inconsistent with creating a new alert through the Splunk UI.

Changing these defaults here to match Splunk's defaults for saved searches.

This change also removes some omitempty tags for integer values when transforming the struct to url parameters. Go's behavior is to consider 0 as an empty value so if the integer was set to 0 the field was not being included in the POST request to Splunk. This made it impossible to set one of these values to 0.

This issue is similar to #35, but concerns integer values.

zscholl commented 3 years ago

👋 Hey @anushjay, anything I can do here to help get this merged?

julada commented 2 years ago

@micahkemp-splunk can we get this merged?