splunk / vault-plugin-secrets-artifactory

vault plugin for artifactory
Apache License 2.0
10 stars 5 forks source link

discard artifactory log #9

Closed M0roSan closed 3 years ago

M0roSan commented 3 years ago

artifactory client log is directed to stderr and it hits size. when it's directed to stdout to debug, it works fine. In this PR, we redirect to io.Discard

codecov-commenter commented 3 years ago

Codecov Report

Merging #9 (72643fc) into main (cd67cf7) will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   40.94%   40.86%   -0.09%     
==========================================
  Files          10       10              
  Lines         674      673       -1     
==========================================
- Hits          276      275       -1     
  Misses        370      370              
  Partials       28       28              
Flag Coverage Δ
unittests 40.86% <100.00%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/artifactory_client.go 17.34% <100.00%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd67cf7...72643fc. Read the comment docs.