search

spmeesseman / vscode-taskexplorer

Run and Manage Tasks for Visual Studio Code
Other
141 stars 30 forks source link

Problems not highlighted when compiling using Makefile #123

Closed yannickowow closed 3 years ago

yannickowow commented 4 years ago

Hi, First of all, thanks for your extension.

I would like to open an issue regarding to how your extension is using problemMatcher for Makefiles. I see by default that your problemMatcher is defined as "cpp"(taskProviderMake.ts:296), but I don't know where it is defined. As is, when compile errors occurs, it does not show in Problem panel. I think it should be defined as $gcc if C/C++ Extensions is installed, or it should be defined from your extension.

Thanks in advance. Regards.

spmeesseman commented 3 years ago

problemmatcher isnt supported for any of the task types, sorry. except for vscode tasks of course since its explicitly defined in the task def. will look into adding in the future

spmeesseman commented 3 years ago

sorry i was wrong, ill have this corrected in next release (via settings, will default to $gcc)

spmeesseman commented 3 years ago

:tada: This issue has been resolved in version 1.29.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

yannickowow commented 3 years ago

Hi Thanks for all ! I did add a comment on your commit. Maybe I am wrong, but your code 

let cPlusPlusExtension = extensions.getExtension("spmeesseman.vscode-taskexplorer");

suggests that you tried to search for C/C++ Extension. (id: ms-vscode.cpptools)