spnda / fastgltf

A modern C++17 glTF 2.0 library focused on speed, correctness, and usability
https://fastgltf.readthedocs.io/v0.8.x/
MIT License
275 stars 42 forks source link

Change c++17 standard visibility to private #32

Closed przemkovv closed 1 year ago

przemkovv commented 1 year ago

Can the visibility of the used C++ standard version be changed from PUBLIC to PRIVATE? https://github.com/spnda/fastgltf/blob/46f28f1355657c42c9f73bfcdde4ba37d05c2a2f/CMakeLists.txt#L90

When it is public, and the project is consumed by another cmake project, the c++17 flag unnecessarily propagates and generates additional warnings if the main project uses e.g., c++20.

like:

 cl : Command line warning D9025 : overriding '/std:c++17' with '/std:c++latest'