search

spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
815 stars 256 forks source link

tinymce 4.0 makes rake assets:precompile fail on heroku #108

Closed pallymore closed 11 years ago

pallymore commented 11 years ago

I just upgraded to 4.0.1 gem today....then I found out rake assets:precompile always time out when I try to deploy it to heroku.

I've been debugging it for hours and couldn't figure out the reason. But I'm pretty sure it's the gem. ( I tried to downgrade it to 3.5.8.2 and it worked just fine.)

I turned on debugging for assets:precomiple, it turned out that the task becomes unbearably slow when it starts compiling tinymce assets. In my local environment, there's about 5 minutes delay after "Compiled tinymce-jquery.js" and "Compiled tinymce/plugins/...."(on heroku it times out here) then it stops when it starts to compile the themes folder. It takes about 18 minutes to compile all the assets in my local with the latest version, (It was only about 2-3 minutes before)

what could be the issue here? I do not serve my assets from a third party server. I have tried to include tinymce paths in config.assets.precompile, still getting the same result.

spohlenz commented 11 years ago

Thanks for reporting. I am able to reproduce this. It looks like Uglifier is not coping with the already minified JS provided by TinyMCE. I'll keep looking into it.

spohlenz commented 11 years ago

This should now be fixed in 4.0.2.

pallymore commented 11 years ago

awesome, I just confirmed it is working now. Thanks!

owenbendavies commented 11 years ago

Yep, works for me too. Thanks for fixing.

geniou commented 11 years ago

I can confirm the fix is working - Thanks.