search

spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
814 stars 257 forks source link

Update for 3.5.8.3 - fix #115

Closed sgentile closed 11 years ago

sgentile commented 11 years ago

The current version of 3.5.8.3 has a bug - and there is a fix which works but is not in the source code...

The issue here is the fix was applied against version 4.x - however, this fix around the function (cleanupStylesWhenDeleting) is also the fix for version 3.5.8.x

https://github.com/tinymce/tinymce/blob/113bd1ceaef1e1de5f2fdf54633d58424817182c/jscripts/tiny_mce/classes/util/Quirks.js

https://github.com/tinymce/tinymce/commit/113bd1ceaef1e1de5f2fdf54633d58424817182c

http://www.tinymce.com/develop/bugtracker_view.php?id=5641

I've locally fixed it and use the gem installed locally - but would like to see if you could update this gem to reflect this change ?

Thanks Steve

spohlenz commented 11 years ago

This and the other updates from the TinyMCE 3.x branch have now been imported into tinymce-rails. Since this does not correspond to an official TinyMCE release, please point your Gemfile to the GitHub repo:

gem 'tinymce-rails', :github => 'spohlenz/tinymce-rails'
sgentile commented 11 years ago

This causes us problems (we are using jRuby with warbler) - although I can see you are not wanting to goto official TinyMCE releases - are they even pushing new releases for 3.x ?

Isn't there a way to just increment the gem version so when we have it in our gemfile ?

spohlenz commented 11 years ago

@sgentile I'd be happy to release a 3.5.9.pre version. Would that work for you?

sgentile commented 11 years ago

yes that would if you don't mind - we are building the gem ourselves for now, but it would certainly make things easier

thanks - your work on this has been very helpful to our team!

Steve

On Mon, Aug 12, 2013 at 6:54 PM, Sam Pohlenz notifications@github.comwrote:

@sgentile https://github.com/sgentile I'd be happy to release a 3.5.9.pre version. Would that work for you?

— Reply to this email directly or view it on GitHubhttps://github.com/spohlenz/tinymce-rails/issues/115#issuecomment-22532111 .

spohlenz commented 11 years ago

Just pushed 3.5.9.pre to rubygems.org.

sgentile commented 11 years ago

Thanks - appreciate you taking the time to do this!