spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
814 stars 257 forks source link

Copy cleanupStylesWhenDeleting patch from TinyMCE 4 for TinyMCE bug #5641 #116

Closed brandonc closed 11 years ago

brandonc commented 11 years ago

Reference issue spohlenz/tinymce-rails#115

TinyMCE Bug #5641: http://www.tinymce.com/develop/bugtracker_view.php?id=5641

spohlenz commented 11 years ago

This is great, thanks for working on this.

However I'm wondering if it will be more sustainable to put together a build script that brings in all of the latest updates in the 3.x branch of the tinymce repo (https://github.com/tinymce/tinymce/tree/3.x). It looks like there are some other important fixes in there.

Last I heard, the TinyMCE guys were going to continue releasing fixes for 3.5 but this could be a good stopgap measure in case that doesn't happen or takes longer than expected.

sgentile commented 11 years ago

just checking back, did this get applied ?

Thanks! Steve

spohlenz commented 11 years ago

@sgentile Not yet. I'm going to pull in the latest updates from the tinymce branch I mentioned above, which includes this fix, as well as:

I should get a chance tomorrow to get this done.

sgentile commented 11 years ago

great - thanks for the update - and we appreciate your work on this - it's been critical to our project and so far it's been outstanding!

spohlenz commented 11 years ago

This and the other updates from the TinyMCE 3.x branch have now been imported into tinymce-rails. Since this does not correspond to an official TinyMCE release, please point your Gemfile to the GitHub repo:

gem 'tinymce-rails', :github => 'spohlenz/tinymce-rails'