spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
812 stars 256 forks source link

YUI compiler's error #148

Closed mazikwyry closed 10 years ago

mazikwyry commented 10 years ago

After bundle_update YUI compiler gives me an error when recompiling assets:

** [out :: bttf.exlabs.co.uk] Faraday::Builder is now Faraday::RackBuilder.
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 31142:8:invalid property id
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 31142:9:syntax error
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 32545:15:missing name after . operator
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68647:15:missing variable name
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] 68648:11:identifier is a reserved word
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68649:19:identifier is a reserved word
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68650:17:missing ; before statement
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68651:17:missing ; before statement
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68652:16:syntax error
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68655:6:missing ) in parenthetical
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68933:15:missing variable name
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68938:13:identifier is a reserved word
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] 68940:41:identifier is a reserved word
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68941:21:syntax error
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 68947:6:missing ) in parenthetical
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 69128:11:invalid return
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 69130:3:syntax error
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] 69575:1:syntax error
 ** [out :: bttf.exlabs.co.uk] 
 ** [out :: bttf.exlabs.co.uk] [ERROR] in /tmp/yui_compress20140717-32118-87jddv
 ** [out :: bttf.exlabs.co.uk] 1:0:Compilation produced 18 syntax errors.

I checked out my application.js line 31142 ( \ [out :: bttf.exlabs.co.uk] 31142:8:invalid property id) and it's

float: 'cssFloat'

from tinymce js. Exacly:

// Included from: js/tinymce/classes/dom/DomQuery.js

/**
 * DomQuery.js
 *
 * Copyright, Moxiecode Systems AB
 * Released under LGPL License.
 *
 * License: http://www.tinymce.com/license
 * Contributing: http://www.tinymce.com/contributing
 */

I found that float is a reserved work in javascipt and that's why YUI have problem with that. You should just put float in ' ' and it should fix that.

spohlenz commented 10 years ago

I've submitted an upstream PR, so hopefully this can be included in the next release.

spohlenz commented 9 years ago

This should now be fixed in the latest release (4.1.3).