search

spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
812 stars 256 forks source link

Assets compression #163

Closed brodock closed 7 years ago

brodock commented 9 years ago

This will generate .gz files for css, javascripts and svg files

brodock commented 9 years ago

@spohlenz the failed specs are false positives (dns problem with github), just re-run it. tell me if you need anything more to get this merged.

spohlenz commented 9 years ago

Sorry for the delay in getting this merged in. I've been working on an alternative compilation method (https://github.com/spohlenz/tinymce-rails/tree/compile-assets) which may end up being a better solution in general (would be great if you could test), but which I still need to test and document. However I plan to keep the existing compilation method as a fallback, for which I'll merge in your PR.

brodock commented 9 years ago

Sorry for the long hiatus... I've tried your branch, and found a little problem. Trying to describe the scenario, before debugging it.

I have a custom skin folder that starts with "tinymce" in the assets folder. It looks like that there is an step being made twice:

here is the shorter ouput:

I, [2015-06-11T16:33:43.052837 #29141]  INFO -- : Writing /project/public/assets/tinymce/skins/custom_skin/content.inline.min-d6cbd87671998e327d3ffbcb941457e6.css
I, [2015-06-11T16:33:43.056717 #29141]  INFO -- : Writing /project/public/assets/tinymce/skins/custom_skin/content.min-193b344a0b074bbc41d624fef2bfa9e1.css
I, [2015-06-11T16:33:43.110202 #29141]  INFO -- : Writing /project/public/assets/tinymce/skins/custom_skin/skin.ie7.min-6caad5b6f556078a4d54d5e45213c1b5.css
I, [2015-06-11T16:33:43.136823 #29141]  INFO -- : Writing /project/public/assets/tinymce/skins/custom_skin/skin.min-33e63bce7f14476347948e5a484c55ea.css

** Invoke assets:sync (first_time)
** Invoke assets:environment
** Execute assets:sync
I, [2015-06-11T16:33:49.582017 #29141]  INFO -- : Removing digest from /project/public/assets/tinymce/skins/custom_skin/content.inline.min-d6cbd87671998e327d3ffbcb941457e6.css
rake aborted!
ArgumentError: same file: /project/public/assets/tinymce/skins/custom_skin/content.inline.min-d6cbd87671998e327d3ffbcb941457e6.css and /project/public/assets/tinymce/skins/custom_skin/content.inline.min.css

/opt/rubies/2.1.5/lib/ruby/2.1.0/fileutils.rb:1578:in `block in fu_each_src_dest'
/opt/rubies/2.1.5/lib/ruby/2.1.0/fileutils.rb:1595:in `fu_each_src_dest0'
/opt/rubies/2.1.5/lib/ruby/2.1.0/fileutils.rb:1577:in `fu_each_src_dest'
/opt/rubies/2.1.5/lib/ruby/2.1.0/fileutils.rb:514:in `mv'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:42:in `block in move_asset'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer.rb:58:in `with_asset'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:5:in `with_asset'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:40:in `move_asset'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:23:in `block (2 levels) in cleanup_assets'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_manifest.rb:110:in `block in remove_digest'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_manifest.rb:22:in `asset_path'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_manifest.rb:106:in `remove_digest'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:22:in `block in cleanup_assets'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_manifest.rb:15:in `block in each'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_manifest.rb:13:in `each_key'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_manifest.rb:13:in `each'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:21:in `cleanup_assets'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer/copy.rb:12:in `call'
/opt/rubies/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/tinymce-rails-0b57091e0acb/lib/tinymce/rails/asset_installer.rb:22:in `install'