search

spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
815 stars 256 forks source link

install = :compile is required with react_on_rails #208

Closed sigmike closed 7 years ago

sigmike commented 7 years ago

config.tinymce.install = :compile This method is intended to eventually become the default, so please try it if it suits your environment and report any issues.

I just wanted to report the opposite, that the default :copy install method fails when the React on Rails gem is installed.

On the first assets:precompile it seems to work but tinymce fails to load its icons. And all subsequent assets:precompile fail with this error:

Errno::ELOOP: Too many levels of symbolic links @ rb_sysopen - /[...]/public/assets/tinymce/plugins/emoticons/img/smiley-smile.gif
spohlenz commented 7 years ago

It looks like the react_on_rails gem is clobbering the assets:precompile which I don't think is good practice. However it looks like they do at least create symlinked non-digested assets (which is what the :compile method does in tinymce-rails). I gather that the :compile method does work properly with react_on_rails?

It is about time that :compile is made the default now -- I will look at changing that for the next release.

sigmike commented 7 years ago

Thank you.