search

spohlenz / tinymce-rails

Integration of TinyMCE with the Rails asset pipeline
Other
813 stars 256 forks source link

File.exists? is deprecated #282

Closed frederikspang closed 2 years ago

frederikspang commented 2 years ago 
tinymce-rails-5.10.2/lib/tinymce/rails/configuration_file.rb:28: warning: File.exists? is deprecated; use File.exist? instead

This PR uses File.exist? instead of deprecated function call.

frenkel commented 2 years ago

Looks good to me @spohlenz

spohlenz commented 2 years ago

Thank you for the PR. I've merged and backported to the older TinyMCE version branches.

rassom commented 1 year ago

@spohlenz Any chance you would merge the File.exists? changes into the 4.9.11 branch also, please?

spohlenz commented 1 year ago

@rassom That should be there in acc5490. However there hasn't been a new gem release since that was added.

rassom commented 1 year ago

@spohlenz Thank you

mschneider85 commented 1 month ago

I'll jump in here for a moment. Are there any plans for releasing a new tinymce-4 gem version that reflects these changes @spohlenz ?

spohlenz commented 1 month ago

@mschneider85 I've just pushed a new release 4.9.11.1 to RubyGems, with some of the more recent compatibility updates including the update to use File.exist?.

mschneider85 commented 1 month ago

Awesome, thank you!