search

spokecommunity / Spoke

mass-contact text/SMS distribution tool
MIT License
3 stars 1 forks source link

Add terraform module #7

Closed jlegrone closed 5 years ago

jlegrone commented 5 years ago

This integrates Ben's terraform from https://github.com/bchrobot/terraform-aws-spoke. It is completely untested by me so far!

jlegrone commented 5 years ago

cc @bchrobot

bchrobot commented 5 years ago

I have mixed feels about this moving into the main Spoke repo versus remaining its own repo. Terraform wants the module as its own repo, but on the other hand, this is a pretty specific module that relies on the codebase and not a Docker image somewhere.

jlegrone commented 5 years ago

I have mixed feels about this moving into the main Spoke repo versus remaining its own repo. Terraform wants the module as its own repo, but on the other hand, this is a pretty specific module that relies on the codebase and not a Docker image somewhere.

Thanks for the link, that makes sense. Since this is so specific though it does seem like we'd be okay not publishing to the registry. I also think it would still be possible to consume the module externally based on this:

https://www.terraform.io/docs/modules/sources.html#modules-in-package-sub-directories

harpojaeger commented 5 years ago

LGTM