When document type is `delete`, there is no need to send `fields` attribute

spokesoftware / aws_cloud_search

Ruby implementation of the AWS CloudSearch 2011 API -- No longer maintained

Other

49 stars 24 forks source link

Closed drewda closed 11 years ago

drewda commented 11 years ago

In fact, doing so will result in a warning like:

 "message" => "\"delete\" has unknown attribute(s): ['fields'] (near operation with index 1; document_id developmentdrewslzimaclocal67)"

Note: Fix for messed up PR #10.

djensen47 commented 11 years ago

It looks like you permanently removed version, was that intended. I thought it was required for several operations, no?

drewda commented 11 years ago

@djensen47 version should still be there. I just removed the comma at the end of that line... or at least that's what I was trying to do.

drewda commented 11 years ago

Does this look alright, @djensen47 ?

djensen47 commented 11 years ago

Thanks for the ping. I see that now thanks.

drewda commented 11 years ago

Thank you.