search

spokestack / react-native-spokestack

Spokestack: give your React Native app a voice interface!
https://spokestack.io
Apache License 2.0
56 stars 13 forks source link

Fix Android null slot parsing #75

Closed space-pope closed 4 years ago

space-pope commented 4 years ago

I spent entirely too long making this testable, and I'm not even sure it's worth the effort, as it entails a little extra work (translating the Java maps to their RN variants) at runtime. I'll leave the performance vs. testability judgement to you.

timmywil commented 4 years ago

I think Noel will need to do a proper review when he gets back, but I want to merge for now to use in our app.