spokestack / react-native-spokestack

Spokestack: give your React Native app a voice interface!
https://spokestack.io
Apache License 2.0
56 stars 13 forks source link

feat: rewrite react-native-spokestack using bob builder #88

Closed timmywil closed 3 years ago

timmywil commented 3 years ago

What this still needs:

Would love @noelweichbrodt's feedback on the Swift part and @space-pope's feedback on the Kotlin part especially.

Feedback on the JS API is also welcome.

Viewing the diff is probably going to be difficult considering all the automated changes from using bob. I suggest looking at example/src/App.tsx for a working example, or even running the example app locally in Android Studio and/or XCode.

timmywil commented 3 years ago

@space-pope And here I assumed the RN config was kebab-case so that it could be passed directly to Android. camelCase is preferred in JS land tho.

space-pope commented 3 years ago

Sample app works as advertised on my test Pixel 1 XL. Thanks for including that!