search

spolu / breach_core

A Browser written in JS. Free. Modular. Hackable.
https://breach.github.io/breach_core/
MIT License
5.39k stars 411 forks source link

Fix tables, 'out' to 'debug' #109

Closed knownasilya closed 10 years ago

knownasilya commented 10 years ago

No more using one table as three tables. Also changed the 'out' link to read 'debug', since it wasn't very obvious what it was.

spolu commented 10 years ago

So keeping one table is important to have a uniform layout and have buttons aligned across sections. As far as out to debug we can call it output if your prefer, but debug is probably misleading.

Can you update your PR?

knownasilya commented 10 years ago

How would you like the tables? You can still have them separate tables, but have the same sized/number of columns.

spolu commented 10 years ago

Always better to let the browser do the layouting, no? Fixed sizes will lead to a bunch of issues

knownasilya commented 10 years ago

@spolu not referring to fixed sizes. Using colgroup and colspan for the tables to say there are this many columns and they take up n of m space.

knownasilya commented 10 years ago

BTW, what's the best way to test this? Would I need to build breach and install breach_core?

spolu commented 10 years ago

The columns would still be disaligned across sections

spolu commented 10 years ago

Have a look to: https://github.com/breach/breach_core/wiki/Building-Breach-from-Source

Section 3 you can use the binary distributions of the ExoBrowser

knownasilya commented 10 years ago

@spolu Thanks!

What about using percentage widths? I think that might be the ticket.

But really we will probably have to go away from tables eventually, since we are doing just a little more then displaying tabular data. This seems like work for a responsive grid..

spolu commented 10 years ago

Sure you can come up with a more complex design but that's not the spirit. There's an effort right now to build a better module manager as a module here: https://github.com/mblarsen/breach-module-manager

spolu commented 10 years ago

Closing for now as this is not top priority + previous comment. Opening the API for the breach-module-manager project is probably more important ATM

knownasilya commented 10 years ago

:smile: