search

spolu / breach_core

A Browser written in JS. Free. Modular. Hackable.
https://breach.github.io/breach_core/
MIT License
5.39k stars 411 forks source link

Safe Mode #163

Open matthewoates opened 10 years ago

matthewoates commented 10 years ago

I installed https://github.com/mblarsen/breach-module-manager, and breach crashed after installation. Breach crashes when I try to restart it, and I can't find where the modules are installed. (on mac) Reinstalling breach does not solve the issue.

I think starting up breach in safe mode is a good option to add, since apparently some modules can crash the entire browser.

spolu commented 10 years ago

Very good point.

Can you provide the log that you get when running Breach from the command line:

/path/to/Breach.app/Contents/MacOS/Breach

You can then remove all local state by deleting:

~/Library/Application Support/breach

This should solve your issue

miketheprogrammer commented 10 years ago

/Users/mhernandez/Library/Application\ Support/breach/

matthewoates commented 10 years ago

Sure.

[2014-07-22T00:44:34.085Z] [index] Breach v0.3.21-alpha.5 Starting...
[2014-07-22T00:44:34.690Z] [core_ui] HTTP Server started on `http://127.0.0.1:62415/`
[2014-07-22T00:44:34.812Z] [auto_updater] Breach v0.3.21-alpha.5 is up to date!
[2014-07-22T00:44:34.902Z] [core_cookies] load_for_key: null
[2014-07-22T00:44:34.902Z] [core_cookies] load_for_key: 
[2014-07-22T00:44:34.904Z] [core_cookies] loaded 0 cookies
[2014-07-22T00:44:35.013Z] ERROR: ENOENT, open '/Users/matt/Library/Application Support/breach/modules/mblarsen/breach-module-manager#master/package.json'
[2014-07-22T00:44:35.014Z] Error: ENOENT, open '/Users/matt/Library/Application Support/breach/modules/mblarsen/breach-module-manager#master/package.json'
[2014-07-22T00:44:35.014Z]     at Error (native)

Breach is now working after deleting that folder. Thanks.

spolu commented 10 years ago

Well that should be catched by the module manager. Definitely a bug

adimasuhid commented 10 years ago

Confirming that this happens when a module is being installed and then breach is closed. I think the modules contents are not downloaded completely.

spolu commented 10 years ago

Yes looks like it. The error should be catched at least and ideally the module should cleaned up and reinstalled under certain circumstances.