spolu / breach_core

A Browser written in JS. Free. Modular. Hackable.
https://breach.github.io/breach_core/
MIT License
5.39k stars 411 forks source link

Module manager does not broadcast `tabs:created` when calling tabs_new #178

Closed t-lutz closed 10 years ago

t-lutz commented 10 years ago

This is the core issues behind #165 and #106: calling core's tabs_new silently creates a background tab but doesn't inform the modules about it.

status: open assigned: t-lutz

t-lutz commented 10 years ago

This PR will enable bug fixes in mod_strip. I suspect it is also possible to simplify some code now, some part of strip (and probably core) were tracking tab creation manually instead of relying on tabs:created events. Will look into that later.

status -> Core review & validation assigned -> @spolu