search

spolu / breach_core

A Browser written in JS. Free. Modular. Hackable.
https://breach.github.io/breach_core/
MIT License
5.39k stars 411 forks source link

Basically nitpicked and made all the variables at the top into one declaration :) #209

Closed coltonfitzgerald closed 10 years ago

morganrallen commented 10 years ago

+1 (but at least it wasn't leading commas)

On Tue, Oct 7, 2014 at 4:46 PM, Colton Fitzgerald notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/rockincolton/breach_core master

Or view, comment on, or merge it at:

https://github.com/breach/breach_core/pull/209 Commit Summary

  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Update core_controls.js
  • Changed variables into one long declaration
  • Changed variables into one long declaration
  • Changed variables into one long declaration

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/breach/breach_core/pull/209.

http://ithoughtyouweretherobot.com Metal and Wire

http://nolonelyguineapigs.com/ Wandering and Rambling

http://morglog.org Old and Neglected.

-----BEGIN PGP PUBLIC KEY BLOCK----- Version: OpenPGP.js v.1.20121007 Comment: http://openpgpjs.org

xsBNBFG3btUBB/9+/WJNOSIuc/praKPaPOweqXV5s7PGRD+HAnNWF/19YAY3 AFtfeoelhhY4sMJoobTaJzcZojznZ1kl/7UuuYCnbJO3Z9kaSMVrVxEZMSLe YmW8Hc4ZsTnl9f05DQFy8ABpAvMLmXJQXh63BbfzjFqNbSWQfLhrubSM2Elq xmN6EsmRyAuEeYlSnal+Di2MlViohpCbbagE2D6AZTUECIamTib6+DuLG4XO b4GGKHR9TXu2qS1VH6hqcvdEz2MDE5OqZzAnBgcF2dvcOdTk9gAOoR1T+qKj IJtg2X0ETbxcPqEXQoXE8VrxN0MLT5JQKTg26+csU4P2w0rEWsUsJombABEB AAHNJU1vcmdhbiBBbGxlbiA8bW9yZ2FucmFsbGVuQGdtYWlsLmNvbT7CwFwE EAECABAFAlG3btwJEG9pFLKaVEfeAAD7hwf+K8LN/kfgi8GTRLiTcuM+hSbm uAeiBY+VaJIQFLzoFlt8A0hBlLNPFNNmUDxdPrMErdHgZ7HtJW/6RANuBTti 5hr3EBguH1GQyK7BbUqJGvaEX4UNRej3uyX3ufXDsIB/3NsKaTyyu+SO0+Hv Cn2DwmlfSXcPhoarx6Turizn/WwgtTN3tqrMWxxiCKWydLH5xYuz+23BLMdc oF/zkbF+7ddFhmyfiFh4Ej9//tsfwPj2cACU3uLTrcwCo7IxUtkrqMF/fhlm LEqjhzDDjq9v7GNWb/5xB2xgTaucJ7/ljuS8nPlZqwCI8NlTgSqC8nyVLyjS yVtOzkItcS0UqyW1Mg== =V/Ia -----END PGP PUBLIC KEY BLOCK-----

spolu commented 10 years ago

This is really cosmetic. What's the rationale va the current form?

coltonfitzgerald commented 10 years ago

It's less characters total in the document xD

morganrallen commented 10 years ago

OH, I read that patch wrong. Leave the var variable = 1;

Its clearer, it copy/pastes better, it substitutes better, and document sizes doesn't matter.

On Wed, Oct 8, 2014 at 10:37 AM, Colton Fitzgerald <notifications@github.com

wrote:

It's less characters total in the document xD

— Reply to this email directly or view it on GitHub https://github.com/breach/breach_core/pull/209#issuecomment-58396110.

http://ithoughtyouweretherobot.com Metal and Wire

http://nolonelyguineapigs.com/ Wandering and Rambling

http://morglog.org Old and Neglected.

-----BEGIN PGP PUBLIC KEY BLOCK----- Version: OpenPGP.js v.1.20121007 Comment: http://openpgpjs.org

xsBNBFG3btUBB/9+/WJNOSIuc/praKPaPOweqXV5s7PGRD+HAnNWF/19YAY3 AFtfeoelhhY4sMJoobTaJzcZojznZ1kl/7UuuYCnbJO3Z9kaSMVrVxEZMSLe YmW8Hc4ZsTnl9f05DQFy8ABpAvMLmXJQXh63BbfzjFqNbSWQfLhrubSM2Elq xmN6EsmRyAuEeYlSnal+Di2MlViohpCbbagE2D6AZTUECIamTib6+DuLG4XO b4GGKHR9TXu2qS1VH6hqcvdEz2MDE5OqZzAnBgcF2dvcOdTk9gAOoR1T+qKj IJtg2X0ETbxcPqEXQoXE8VrxN0MLT5JQKTg26+csU4P2w0rEWsUsJombABEB AAHNJU1vcmdhbiBBbGxlbiA8bW9yZ2FucmFsbGVuQGdtYWlsLmNvbT7CwFwE EAECABAFAlG3btwJEG9pFLKaVEfeAAD7hwf+K8LN/kfgi8GTRLiTcuM+hSbm uAeiBY+VaJIQFLzoFlt8A0hBlLNPFNNmUDxdPrMErdHgZ7HtJW/6RANuBTti 5hr3EBguH1GQyK7BbUqJGvaEX4UNRej3uyX3ufXDsIB/3NsKaTyyu+SO0+Hv Cn2DwmlfSXcPhoarx6Turizn/WwgtTN3tqrMWxxiCKWydLH5xYuz+23BLMdc oF/zkbF+7ddFhmyfiFh4Ej9//tsfwPj2cACU3uLTrcwCo7IxUtkrqMF/fhlm LEqjhzDDjq9v7GNWb/5xB2xgTaucJ7/ljuS8nPlZqwCI8NlTgSqC8nyVLyjS yVtOzkItcS0UqyW1Mg== =V/Ia -----END PGP PUBLIC KEY BLOCK-----

spolu commented 10 years ago

I agree. I'm not a big fan

coltonfitzgerald commented 10 years ago

The thing is though, JSLint picks it up as an issue. Apparently it says that all variables should be defined in one. I mean, obviously it's not a big deal but it's fun to contribute anyways :)

morganrallen commented 10 years ago

Are you sure that is not your settings? Because that is terrible if that is their default.

On Wed, Oct 8, 2014 at 3:45 PM, Colton Fitzgerald notifications@github.com wrote:

The thing is though, JSLint picks it up as an issue. Apparently it says that all variables should be defined in one. I mean, obviously it's not a big deal but it's fun to contribute anyways :)

— Reply to this email directly or view it on GitHub https://github.com/breach/breach_core/pull/209#issuecomment-58440127.

http://ithoughtyouweretherobot.com Metal and Wire

http://nolonelyguineapigs.com/ Wandering and Rambling

http://morglog.org Old and Neglected.

-----BEGIN PGP PUBLIC KEY BLOCK----- Version: OpenPGP.js v.1.20121007 Comment: http://openpgpjs.org

xsBNBFG3btUBB/9+/WJNOSIuc/praKPaPOweqXV5s7PGRD+HAnNWF/19YAY3 AFtfeoelhhY4sMJoobTaJzcZojznZ1kl/7UuuYCnbJO3Z9kaSMVrVxEZMSLe YmW8Hc4ZsTnl9f05DQFy8ABpAvMLmXJQXh63BbfzjFqNbSWQfLhrubSM2Elq xmN6EsmRyAuEeYlSnal+Di2MlViohpCbbagE2D6AZTUECIamTib6+DuLG4XO b4GGKHR9TXu2qS1VH6hqcvdEz2MDE5OqZzAnBgcF2dvcOdTk9gAOoR1T+qKj IJtg2X0ETbxcPqEXQoXE8VrxN0MLT5JQKTg26+csU4P2w0rEWsUsJombABEB AAHNJU1vcmdhbiBBbGxlbiA8bW9yZ2FucmFsbGVuQGdtYWlsLmNvbT7CwFwE EAECABAFAlG3btwJEG9pFLKaVEfeAAD7hwf+K8LN/kfgi8GTRLiTcuM+hSbm uAeiBY+VaJIQFLzoFlt8A0hBlLNPFNNmUDxdPrMErdHgZ7HtJW/6RANuBTti 5hr3EBguH1GQyK7BbUqJGvaEX4UNRej3uyX3ufXDsIB/3NsKaTyyu+SO0+Hv Cn2DwmlfSXcPhoarx6Turizn/WwgtTN3tqrMWxxiCKWydLH5xYuz+23BLMdc oF/zkbF+7ddFhmyfiFh4Ej9//tsfwPj2cACU3uLTrcwCo7IxUtkrqMF/fhlm LEqjhzDDjq9v7GNWb/5xB2xgTaucJ7/ljuS8nPlZqwCI8NlTgSqC8nyVLyjS yVtOzkItcS0UqyW1Mg== =V/Ia -----END PGP PUBLIC KEY BLOCK-----

spolu commented 10 years ago

We all agree to close it?

@rockincolton if you want to keep contributing, you could be super useful on this: https://github.com/breach/exo_shell/issues/161

We need to write some libraries. Any language you master other than JS?