spongedsc / pathways

Pathways: multi-modal AI/ML models on discord
GNU Affero General Public License v3.0
3 stars 1 forks source link

Replace wastebin with custom viewer #86

Closed artifishvr closed 6 months ago

artifishvr commented 6 months ago

This PR replaces the wastebin integration with https://github.com/spongedsc/pathways-web

daniwasonline commented 6 months ago

Could we turn this one into an RFC? This seems like quite a big change that might be good if we develop this in a deviant branch to scope out all of the edge cases with this.

(Also, yay we're doing the web stuff omg!! I thought you didn't want to do it before because of too much tech debt?)

artifishvr commented 6 months ago

I thought you didn't want to do it before because of too much tech debt?

learning dbs on the edge (+ drizzle, + api keys) seemed fun

Could we turn this one into an RFC?

uuggggggghhhhhhh

daniwasonline commented 6 months ago

I thought you didn't want to do it before because of too much tech debt?

learning dbs on the edge (+ drizzle, + api keys) seemed fun

i get this! that's a really fair point lol

Could we turn this one into an RFC?

uuggggggghhhhhhh

i think if we're going to have our own logging solution, we should standardise the API as to allow for multiple implementations (i myself have no time to build another + the web repo is a really good excuse for me to learn sveltekit!) or just having a general reference for how all the API calls should work

artifishvr commented 6 months ago

or just having a general reference for how all the API calls should work

So can I make some api docs in the web repo later and call that good? It's incredibly simple and likely very breakable but i mean that's not this repo's problem :trollface:

daniwasonline commented 6 months ago

So can I make some api docs in the web repo later and call that good?

i mean that works too yeah, give me a bit to take a look at the code here though bc i might refactor it a bit if thats ok w u

(i want to put the web connector shit into a class so its cleaner and methods are accessible globally)

artifishvr commented 6 months ago

i might refactor it a bit if thats ok w u

Absolutely, sure! The code here really is not perfect (cause I wrote it) and honestly I expected that back when I wrote the wastebin implementation

daniwasonline commented 6 months ago

Absolutely, sure! The code here really is not perfect (cause I wrote it) and honestly I expected that back when I wrote the wastebin implementation

a) stfu ur chill ur code's fine, wastebin was fine but we should be making things a lot more clean/safe if the bot's consuming an internal thing (the web repo can be wacky because i usually build to assume that the response from anything is wrong and needs a fallback)

b) hol up im binging skibidi toilet 70-73, i am ALMOST done i swear

artifishvr commented 6 months ago

b) hol up im binging skibidi toilet 70-73, i am ALMOST done i swear

LOOK HOLD ON THIS VIDEO IS SO COOL YOU HAVE TO SEE IT https://youtu.be/PunVHiOxUEk?t=14

artifishvr commented 6 months ago

oh also completely offtopic but uuh do you think UUIDS or snowflakes or something should be used in the web repo instead of a serial

daniwasonline commented 6 months ago

b) hol up im binging skibidi toilet 70-73, i am ALMOST done i swear

LOOK HOLD ON THIS VIDEO IS SO COOL YOU HAVE TO SEE IT

https://youtu.be/PunVHiOxUEk?t=14

do you fucking think i'm 4? really? fuck you.

i'm 5. get it right. i've moved on from cocomelon and have joined the real alphas with ✨ skibidi

(i'm joking i'm not actually 5)

artifishvr commented 6 months ago

i'm 5.

github ban this user

daniwasonline commented 6 months ago

oh also completely offtopic but uuh do you think UUIDS or snowflakes or something should be used in the web repo instead of a serial

we use a mix of uuids and snowflakes as standard identifiers already, i'm sure it'll be okay if we use serial since all three are just structured strings. plus it might be good in case of uuid causing namespace conflicts and issues, i'm thinking that maybe we should switch away from uuids altogether in the main codebase and use the t3™️ certified replacement (i forgot what it's called)

artifishvr commented 6 months ago

https://github.com/spongedsc/pathways-web/blob/main/docs/api.md

oh also completely offtopic but uuh do you think UUIDS or snowflakes or something should be used in the web repo instead of a serial

web repo now uses a 10 character nanoid (https://remember.gayse.cx/zjxHAc2TNP) (god i love drizzle)