search

sponte / Powershell.Deployment

Powershell scripts that automated component deployment. Supports windows services (srvany.exe, NServiceBus, TopShelf) and websites.
MIT License
15 stars 8 forks source link

Newly created website is in Started state #34

Open margani opened 6 years ago

margani commented 6 years ago

We realized that when we create a new service here, the created service is in stopped mode and we need to start it later on. We like this behaviour.

But for creating a website here, the created website is in Started state. We don't like this behaviour because our load balancer picks up the site whilst it is not ready resulting in errors.

Can we have the same behaviour for creating websites as we have for creating services (i.e. create them in a stopped state)?

We know that the Powershell command for creating an IIS site do not allow starting in a stopped state. However, we found a solution: We can stop the app pool, immediately after it is created, before then creating the web site (In this way).

This would be a breaking change, that may affect users who assume a new web site will start without a further command. Would you be happy to accept a pull request with such a breaking change?

@taliesins do you have an opinion?

ma499 commented 6 years ago

@sponte do you have an opinion on this? Would a PR be accepted?

sponte commented 6 years ago

Hey

The change sounds reasonable however default option should be to start the app pool by default and have an option to have it stopped if required. This will make the change backwards compatible and provide you with required functionality.

@taliesins does this sound good to you?