spookbench / final_destination

0 stars 0 forks source link

[BUG] Double jump doesn't always work #5

Open Tsukreya opened 4 years ago

Tsukreya commented 4 years ago

Describe the bug The double jump sometimes refuses to work. Probably an input handling issue.

Platform: Windows

Version/build date: Windows build version 14

To Reproduce Steps to reproduce the behavior:

  1. Run the game
  2. Acquire double jump
  3. Spam jumps and directional keys / hold directional keys while double jumping
  4. Get locked out of double jumping, until you let go of directional keys / spam some more.

Expected behavior I should be able to spam the keyboard all I want and not get locked out of double jumping.

Screenshots Video with my inputs on-screen. https://i.ahegao.agency/CkNwrGM3hg.mp4?key=NAMMebTSpDluQw

Tsukreya commented 4 years ago

Is_on_floor() returns False 1/4 of the time https://godotengine.org/qa/25969/when-is-is_on_floor-function-true-excatly?show=25969#q25969, to fix set Safe Margin of player collision to 1 (anything above 0.15ish seems to be working fine actually). Walking into a wall makes is_on_floor() return False too though.

Tsukreya commented 4 years ago

Implement is_on_wall() to checking if player is able to jump, somehow.

Tsukreya commented 4 years ago

It's tied to FPS, seems to be working alright at 120fps, please lock it at that or something, godot is smartn't.