spooky-oysters / Bangazon-Command-Line-Application

0 stars 1 forks source link

Data interface boilerplate file #13

Closed DreRandaci closed 6 years ago

DreRandaci commented 6 years ago

Link to Ticket

Closes #12 Create Database Interface

Description of Proposed Changes

Steps to Test

git fetch --all
git checkout dr-DbInterface

Impacted Areas in Application

List general components of the application that this PR will affect:

Mentions @username

Tag users that need to review this code

Definition of Done

  1. The project must be fully documented. This includes the following:
    1. Complete README that documents the steps to install the code, how to install any dependencies, or system configuration needed.
    2. Every class must be documented with purpose, author, and methods.
    3. Every method must be documentation with purpose and argument list - which itself must contain a short purpose for each argument.
  2. The project must be able to run fully, and without errors, on each teammate's system.
  3. Fulfills every requirement. Every line of code has been peer reviewed.
  4. For projects that require unit testing, core functionality must be identified and have at least one test for each.
kimberly-bird commented 6 years ago

👍

Chewieez commented 6 years ago

I think line 30 should not include the word Environment. This is a little confusing since this isn't an environment variable, it's going to hold the contents of an environment variable.

Look at line 67 and reword

I would reword line 103 to: // Loop runs once and assigns the inserted items ID to the initialized insertedItemId variable

I would move the If it throws an exception, create the table from line 130 to 134 or 135, right where the code for the exception is. It's confusing to read it in the code for the success.

Chewieez commented 6 years ago

👍 good jorb