spookybear0 / laserforce_ranking

Ranking and matchmaking of laser tag players
https://laserforce.spoo.uk
MIT License
4 stars 2 forks source link

SM5 replay score doesn't match actual score in entity_end #84

Closed EboMike closed 1 month ago

EboMike commented 6 months ago

Example: http://localhost:8000/game/sm5/118/replay

Most players have a higher computed score than the actual score as shown in EntityEnd. It's always off by multiples of 100.

EboMike commented 1 month ago

Okay, going to put some findings in here so I don't forget:

  1. The replay scores are equal or too high, but never lower than the actual entity_end score.
  2. The difference is always a multiple of 100. It ranges quite a bit, from 0 to 1200.
  3. Biggest difference in this game is High Tower (1200 points). The score composition indicates that a lot of negative points came from zapping the own team (-600 points?!).
EboMike commented 1 month ago

I see events where a player is zapping someone on their own team, but it's counted like a tag on the opposing team (so the player was actually awarded points).

I need to see if the TDF says DOWNED_OPPONENT instead of DOWNED_TEAM, or if there's a mistake on our end. I don't have the TDF for 118, so I need to look into the database, which is a pain in the ass.

EboMike commented 1 month ago

Yep, Laserforce doesn't store friendly fire events correctly.