search

spookybear0 / laserforce_ranking

Ranking and matchmaking of laser tag players
https://laserforce.spoo.uk
MIT License
4 stars 2 forks source link

"Team lives remaining" is wrong #94

Closed EboMike closed 5 months ago

EboMike commented 6 months ago

https://laserforce.spoo.uk/game/sm5/184

Fire team has one player with 4 lives, but total shows 0 lives.

EboMike commented 6 months ago

Oh wait, that's average. I played myself by mixing average and minimum in the "totals". Maybe all averages should have decimal point to make it more obvious.

spookybear0 commented 6 months ago

Doesn't it make more sense for lives specifically to be total rather than an average?

EboMike commented 6 months ago

Both kinda make sense in their own way.... but I think I'll just make it the total. Otherwise I'd have to change the data model, since it's currently an integer for the column.

EboMike commented 6 months ago

Okay, I changed it to sum for lives and shots. Honestly it's a bit weird. I think average makes more sense.