search

spookylukey / django-paypal

A pluggable Django application for integrating PayPal Payments Standard or Payments Pro
MIT License
729 stars 208 forks source link

Increased max_length from 40 to 64 for fields: address_city, address_state. #209

Open bilabon opened 5 years ago

bilabon commented 5 years ago

Got an error in handling IPN form: _Invalid form. (addresscity: Ensure this value has at most 40 characters (it has 44).) Please allow this pull request.

spookylukey commented 5 years ago

Could you tell me where the new figure 64 comes from? Are there some docs from PayPal's side about what the new max lengths are? (I think the old ones were based on PayPal docs)

bilabon commented 5 years ago

According to the docs you are right. There is a limit of 40 characters https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNandPDTVariables/#buyer-information-variables But paypal doesn't validate it on the checkout form and some customers write more than 40 characters in these fields. For example, I completed test payment with address_city length of 55 characters: https://i.imgur.com/KUBKgtU.png . In my invalid_ipn_received signal I got: {'address_city': 'Central Falls Phone 123456789123456789123456789123456789’} So I think it would be more convenient to allow a little bit more characters for these fields.

On Mar 19, 2019, at 8:13 PM, Luke Plant notifications@github.com wrote:

Could you tell me where the new figure 64 comes from? Are there some docs from PayPal's side about what the new max lengths are? (I think the old ones were based on PayPal docs)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spookylukey/django-paypal/pull/209#issuecomment-474506815, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKH4bXW3uwBx5tEGEPtMJfoTtK8fStdks5vYSiugaJpZM4b6B1K.

spookylukey commented 5 years ago

OK, so this is a PayPal bug, they should not be sending data longer than their specified max length. Most likely they changed something and forgot to update their docs. Perhaps you could contact them and get an official answer on what the lengths should be?