django 4 compatibility: changing deprecated force_text to force_str

spookylukey / django-paypal

A pluggable Django application for integrating PayPal Payments Standard or Payments Pro

MIT License

729 stars 208 forks source link

django 4 compatibility: changing deprecated force_text to force_str #246

Closed newearthmartin closed 2 years ago

newearthmartin commented 2 years ago

django-paypal gives a compilation error with Django 4 because of the deprecated force_text

spookylukey commented 2 years ago

Note to self: we may have issues with Python 2.7 here, which is still officially supported by django-paypal! I'm surprised that the Python 2.7/ Django 1.11 test suite passes because force_str in Django 1.11 + Python 2 means "force to bytes" - more investigation required.

spookylukey commented 2 years ago

So the affected code was actually dead, and could be removed. However there were a bunch of other issues, fixed in #247 . Thanks for the PR!

newearthmartin commented 2 years ago

You're welcome ! I didn't know how to run the tests. Thanks for #247