search

spookylukey / django-paypal

A pluggable Django application for integrating PayPal Payments Standard or Payments Pro
MIT License
729 stars 208 forks source link

bug fix, although I cannot tell how this ever worked, so really I jus… #278

Open jmordkoff opened 1 year ago

jmordkoff commented 1 year ago

…t want to start the discussion.

As far as I can tell, forms.fields has never had a member call EMPTY_VALUES. There is empty_values, and there is django.core.validators.EMPTY_VALUES. So how did this code ever work?

spookylukey commented 1 year ago

Looks like it was removed here: https://github.com/django/django/commit/129583a0d3cf69b08d058cd751d777588801b7ad#diff-5a7bf4b2271ba7a2dcce4b0bbef40199985f02cbce6aeebf2111401c2342d57b

As you can see, there is a warn_untested() call inside this code, which is why the problem wasn't caught.

Are you actually using it? If not, my preference is to simply remove this code. If you are, then I require a test to be added that covers any code that will be changed. The test must fail without the changes, and pass with them. Thanks!