Closed diegoaldarondo closed 2 years ago
Yes, it would be good to have logging statements instead of print statements. For the choice of using absl for logging, it makes sense to add this dependency only if we want to use its unit testing framework as well. Are we considering absl for unit tests as well?
absl
is currently required for cluster/multi_gpu_test.py
and tests/cli_test.py
on the as_landing
and automated_multi_instance_refactor
branches. I don't think either testing suite requires anything from absl
that isn't supported by unittest
, so we could just change all references to absl
to use unittest
equivalents and skip the added dependency until we need additional absl
functionality.
@data-hound any update on this?
The code changes with logging statements are in as_logging. But, they have not been tested, yet. Once I test and verify things are working as expected, it will be good to merge.
I have finished testing the as_logging branch using a dannce-predict run
Can we roll in the
logging
orabsl.logging
modules to better log our debugging print statements? Would help with sharing our log files, and reduce the printed output when not debugging.