spoorn / sodium-forge

A Fabric..... I mean Forge mod designed to improve frame rates and reduce micro-stutter
GNU Lesser General Public License v3.0
28 stars 8 forks source link

Tinker's Construct tools and parts are colorless. #163

Open FlameyFaucet opened 2 years ago

FlameyFaucet commented 2 years ago

Expected Behavior

Tinker's Construct tools and parts should show with the correct color for their material.

Actual Behavior

All parts and tools appear white, regardless if it is crafted or viewed from JEI.

Reproduction Steps

  1. Install Tinkers Construct 1.16.5-3.1.2.265 with it's dependency, Mantle 1.16.5-1.6.123

System Information

Everything was fine until i updated Tconstruct and Mantle to the versions mentioned, which are the latest. I took a peek into their changelogs and saw that they changed a bunch of rendering stuff which might've been the cause.

KnightMiner commented 2 years ago

For the record, tools are colored using the same logic forge uses to tint it's universal buckets, so I suspect you will find colored fluids are white as well. Has it do with the forge lighting pipeline I believe

BGazotti commented 2 years ago

For the record, tools are colored using the same logic forge uses to tint it's universal buckets, so I suspect you will find colored fluids are white as well. Has it do with the forge lighting pipeline I believe

Spot-on, Knight. But not all fluids and not all the time - for instance, Slimesteel keeps its nice bluish color for me, and all molten metals keep their color when flowing out of a faucet, but not when inside a melter, but they look normal inside the multiblock smeltery. Weird stuff.

KnightMiner commented 2 years ago

Slimesteel is not tinted, it has a unique texture. That is why I clarified "colored fluids". Most of our molten metals fit this category, as does vanilla water (though it does not use the forge model)

As for the smeltery, it does not go through the model system, so it is colored in a more direct way. I assume whatever optimization Sodium applies only affects models and not rendering in general, or you would notice it on sheep for instance.

EndangeredNayla commented 2 years ago

Anyone know what part of sodium to disable to get the tools to return?

luckyu19 commented 2 years ago

Anyone know what part of sodium to disable to get the tools to return?

Last time I've checked, turning each of them and turning all of the available configs off doesn't help.

luckyu19 commented 2 years ago

Did some testing as people reported some config editing fixes the issue. Under sodium-mixin.properties file, adding this line fixes the issue: mixin.features.item=false (mixin.features=false also works, but it meant most of Halogen optimizations doesn't work, I think?)

I've checked the mixin file available on github, and tried mixin.features.item.MixinItemRenderer=false but it didn't work. Hopefully this is enough to debug the issue.

Cinnamon-Addict commented 2 years ago

"> Did some testing as people reported some config editing fixes the issue. Under sodium-mixin.properties file, adding this line fixes the issue: mixin.features.item=false (mixin.features=false also works, but it meant most of Halogen optimizations doesn't work, I think?)

I've checked the mixin file available on github, and tried mixin.features.item.MixinItemRenderer=false but it didn't work. Hopefully this is enough to debug the issue."

any clue where in the files this is? as halogen's sodium-mixins.properties file is a bit annoying to read

DaBlizz commented 2 years ago

any clue where in the files this is? as halogen's sodium-mixins.properties file is a bit annoying to read

If you're asking about where the mixin.features.item=false option is, it's something you need to add yourself. The file should be one large comment at the top and only one line disabling the lithium AI under that by default. You can add the new line under that one.

Cinnamon-Addict commented 2 years ago

any clue where in the files this is? as halogen's sodium-mixins.properties file is a bit annoying to read

If you're asking about where the mixin.features.item=false option is, it's something you need to add yourself. The file should be one large comment at the top and only one line disabling the lithium AI under that by default. You can add the new line under that one.

I was able to find it, I just paste it below the last line of code in Halogen's sodium-mixins.properties file

NuggetYTCZ commented 1 year ago

Slimesteel is not tinted, it has a unique texture. That is why I clarified "colored fluids". Most of our molten metals fit this category, as does vanilla water (though it does not use the forge model)

As for the smeltery, it does not go through the model system, so it is colored in a more direct way. I assume whatever optimization Sodium applies only affects models and not rendering in general, or you would notice it on sheep for instance.

it doesn't work for me

NuggetYTCZ commented 1 year ago

NVM it worked thx