spoorn / sodium-forge

A Fabric..... I mean Forge mod designed to improve frame rates and reduce micro-stutter
GNU Lesser General Public License v3.0
28 stars 8 forks source link

Roadrunner Compat Issue #184

Open Vaengence opened 2 years ago

Vaengence commented 2 years ago

I believe this is the same realm as Optifine and Fabric ports, but there is a brand new Mod that will cause issues with this which i doscovered by accident.

https://pastebin.com/uNW0En40

This Roadrunner mod seems brand new with first release 8x days ago and added to Enigmatic Beta 4x days ago https://www.curseforge.com/minecraft/mc-mods/roadrunner

Meaning its likely few people will be aware of the potential conflict and simply just get crashes starting the client like I did. I am "guessing" it just has to be added to list of incompatible mods - just letting you know.

FlameyFaucet commented 2 years ago

It's a lithium port to Forge for 1.16.5. Halogen also contains a lithium port for Forge 1.16.5. You can guess it doesn't end well.

Vaengence commented 2 years ago

I was aware of that. The point was that this mod was brand new and unlike most ports of Lithium which are manually installed by the user (and can see on the main page the "incompatible list") this mod was added to the Mod Pack itself and is only a week old, meaning like me, people may download the pack and then attempt to use this mode - which would have worked a week ago - and suddenly have lots of issues starting it.

IE like I just did and spent an hour trying to work out what on earth was happening until I tracked it down to this mod added by the Pack author.

This was just a heads up given the mod was so new and in built to a large popular pack and to maybe head off others posting issues that suddenly their packs are not working when using this mod and don't know why ^^

robjw95 commented 2 years ago

Is there a way to disable lithium portion of the mod so as to be compatible?

FlameyFaucet commented 2 years ago

I think there's a mixin config that you can add into the sodium.mixins file to disable it, but i don't know the exacts.

purrloftruth commented 2 years ago

In #111, @spoorn expressed desire to potentially remove all of the Lithium/Phosphor code completely from this mod (https://github.com/spoorn/sodium-forge/issues/111#issuecomment-886264903). The existence of an up-to-date, actively maintained mod like RoadRunner might be a good reason to do so sooner rather than later.

ghost commented 2 years ago

Hey what's up with the config? I thought that by disabling lithium in the mixin file it would allow RoadRunner to do it's stuff, but it still seems to be crashing.

sodium-mixins.properties:
# This is the configuration file for Sodium.
#
# You can find information on editing this file and all the available options here:
# https://github.com/jellysquid3/sodium-fabric/wiki/Configuration-File
#
# By default, this file will be empty except for this notice.
#
# Uncomment below line for vanilla seed gen parity
# mixin.gen.fast_layer_sampling=false
#
# Comment out or remove the below line to enable Lithium
# Lithium pathfinding conflicts with some mods such as More Villagers
mixin.ai=false

Isn't this supposed to disable it correctly?

FlameyFaucet commented 2 years ago

No, that just disables Lithium's pathfinding.